Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"es-enable-ssl" is always overwritten when you use CLI "setup:config:set" #832

Closed
pravalitera opened this issue Mar 21, 2018 · 3 comments
Closed

Comments

@pravalitera
Copy link

pravalitera commented Mar 21, 2018

es-enable-ssl is always changed when you use CLI "setup:config:set"

Preconditions

Magento Version : 2.2.2 CE
ElasticSuite Version : 2.5.5
Environment : Developer

Steps to reproduce

  1. use the CLI command "setup:config:set"

Expected result

  1. to not modify es-enable-ssl if not specified

Actual result

  1. always ask to overwrite es-enable-ssl

smile_elasticsearch_cli_bug

@afoucret
Copy link
Contributor

Hi @pravalitera,

I spotted a bug in the config:set command that make the Magento\Framework\Setup\Option\FlagConfigOption almost impossible to use.

I will report to Magento and propose a PR for this.

Thx for reporting.

@afoucret
Copy link
Contributor

Seems that using the Magento\Framework\Setup\Option\FlagConfigOption is not a good idea since it does not allow to disable the SSL through the config:set once enabled.

I changed the implementation and the --es-enable-ssl param now take a value (0 or 1).

PR #835 implement the fix and will be part of release 2.5.7.

@pravalitera
Copy link
Author

If only bug fixes were as fast on official Magento2 Github ^_^

Thx for your commit 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants