Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dungeon entrance room's physical pos sometimes gets misdetected #905

Open
GatienDoesStuff opened this issue Aug 9, 2024 · 2 comments
Open
Labels
bug Something isn't working

Comments

@GatienDoesStuff
Copy link
Contributor

What happened?

Rarely, the entrance room for dungeons gets detected at the wrong location, which breaks the new door highlighter added by #879, as it relies on the map to determine door positions instead of detecting blocks.

It seems to also break secret detection but I haven't seen this happen enough times to confirm if it is really the root cause for that issue.

Screenshots

No response

Log output

Problematic detection :
[12:41:13] [Render thread/INFO]: [Skyblocker Dungeon Secrets] Started dungeon with map room size 16, map entrance pos ( 8.500E+1 1.050E+2), player pos (-57.13406938252408, 69.0, -34.940132857258206), and physical entrance pos (-8.000E+0 -8.000E+0)

Accurate detection :
[12:17:34] [Render thread/INFO]: [Skyblocker Dungeon Secrets] Started dungeon with map room size 16, map entrance pos ( 2.500E+1 1.050E+2), player pos (-152.41298109209808, 69.0, -36.86233108903359), and physical entrance pos (-1.680E+2 -4.000E+1)

Minecraft Version

1.21.0

Skyblocker Version

Any with dungeon features

Additional context

Regarding the above log, in very few cases, the detected physical position is wrong, though the map pos remain accurate.
(refer to player coords & physical room coords, and you'll see they don't match)

@GatienDoesStuff GatienDoesStuff added the bug Something isn't working label Aug 9, 2024
@GatienDoesStuff
Copy link
Contributor Author

This fortunately remains really rare, and for most runs, no issues are experienced.

@kevinthegreat1
Copy link
Collaborator

Aaron said that this only happens when the physical entrance pos is (-8.000E+0 -8.000E+0). I'm putting this here so we can investigate later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants