Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of healing code #120

Open
thomthom opened this issue Feb 25, 2014 · 3 comments
Open

Improve handling of healing code #120

thomthom opened this issue Feb 25, 2014 · 3 comments

Comments

@thomthom
Copy link
Member

See #110. The slow down is due to the healing which is triggered by tiny faces being lost because they are too small for SketchUp's tolerance.

Look into improving the performance of healing.

Also look into providing a warning for very large models so the user is aware the operation might take a long time.

Perhaps detecting edges that are below SketchUp's tolerance would help in bailing from the healing method?

@thomthom thomthom added this to the Version 2.2 milestone Feb 25, 2014
@jimfoltz
Copy link
Contributor

Just a thought - have the importer always import at an exaggerated scale, then scale down to the user's selected units after?

@thomthom
Copy link
Member Author

I was thinking of that. Though that could make for issues during copy and paste - you might end up with copies in the original scale of the definition. At least if the group is converted to a component and then picked from the component browser - which is not unlikely.

There's also the issue of all too large units triggering OpenGL clipping...

@thomthom
Copy link
Member Author

Hmm... this keeps coming back. Blindly trying to heal will often lead to SketchUp freezing up for way too long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants