Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Option to save Frozen state on per-type-basis #35

Open
SkepticMystic opened this issue Nov 13, 2021 Discussed in #33 · 6 comments
Open

FR: Option to save Frozen state on per-type-basis #35

SkepticMystic opened this issue Nov 13, 2021 Discussed in #33 · 6 comments

Comments

@SkepticMystic
Copy link
Owner

Discussed in #33

@SkepticMystic
Copy link
Owner Author

Implemented in 0.10.0

@FelipeRearden
Copy link

Implemented in 0.10.0

Working on version 0.10.0 in Obsidian 0.12.19

I have one little comment to share with you:

The frozen status is lost when switching between types and coming back

  • It's easier to explain following my steps:

Step 1: Open Graph Panel in Co-Citations
Step 2: apply frozen
Step 3: change to Adamic Adar type (adamic is unfrozen by default which is 100% right!)
Step 4: get back to Co-Citations it is unfrozen :(

In my humble opinion would be great to store/save the frozen/unfrozen status of a type A when switching to type B and getting back to type A

Feel absolutely free to discard this. I was just my instinct of tester/user when using the other types

Have a great day!

@SkepticMystic
Copy link
Owner Author

Ahhh interesting... so the FR is to save the frozen status on a per-type basis?
I think that would be optional, so I'd make it a setting. I can also add a cmd to free/unfreeze the current view (but that's a different thing)

@SkepticMystic SkepticMystic reopened this Nov 13, 2021
@SkepticMystic SkepticMystic changed the title FR: Freeze current view FR: Option to save Frozen state on per-type-basis Nov 13, 2021
@FelipeRearden
Copy link

FelipeRearden commented Nov 13, 2021

Ahhh interesting... so the FR is to save the frozen status on a per-type basis?

Yes!!!! I'm just stating to understand all types but my feeling is that switching between types to find unseen relations :)

The workflow is very dynamic switching between types and the backlinks pane to search for content !

I think that would be optional, so I'd make it a setting.

100% agree @SkepticMystic !!! It's the best way to implement this!

I can also add a cmd to free/unfreeze the current view (but that's a different thing)

Would be AMAZING !!!!! For keyboard lovers this will be fantastic !

If you allow me one comment about this possible future feature :) ->

-> Only one command Graph Analysis: Frozen/Unfrozen the Active Type . This way We can have only one hotkey applied to all types !!!

Let me know if you want me to create an FR for that.

What a great plugin @SkepticMystic !!!!

@HEmile
Copy link
Collaborator

HEmile commented Nov 13, 2021

so I'd make it a setting

I don't see why this needs to be optional, sounds hard to explain and few people would want to change this i think.

If I understand @FelipeRearden correctly, it would save the frozen status and the active list when switching. Technically doable but would require a refactor to be able to save this properly as its currently unloaded on switch.

@SkepticMystic
Copy link
Owner Author

@HEmile I guess I agree with it not needing to be optional.

And yes, it would require saving the latest results of each component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants