88f9c8d033 style: modernize the style of SockMan::AcceptConnection()
2b045fde21 net: split CConnman::AcceptConnection() off CConnman
240a174cd1 style: modernize the style of SockMan::BindListenPort()
3a4dba0a67 net: split CConnman::BindListenPort() off CConnman
d646b96253 net: reduce CAddress usage to CService or CNetAddr
+ echo

+ test/lint/commit-script-check.sh HEAD~..HEAD
+ RUST_BACKTRACE=1
+ /lint_test_runner/test_runner
Args used        : 215
Args documented  : 227
Args undocumented: 0
set()
Args unknown     : 12
{'-zmqpubrawblock', '-zmqpubhashtx', '-zmqpubsequence', '-zmqpubrawblockhwm', '-testdatadir', '-zmqpubrawtx', '-zmqpubhashblock', '-includeconf', '-zmqpubsequencehwm', '-zmqpubhashblockhwm', '-zmqpubrawtxhwm', '-zmqpubhashtxhwm'}
All checks passed!
src/crc32c in HEAD currently refers to tree 454691a9b89ee8b9e1f71a48a7398edba49c3805
src/crc32c in HEAD was last updated in commit 5d45552fd4303f8d668ffbc50cce1053485aeead (tree 454691a9b89ee8b9e1f71a48a7398edba49c3805)
GOOD
src/crypto/ctaes in HEAD currently refers to tree 1b6c31139a71f80245c09597c343936a8e41d021
src/crypto/ctaes in HEAD was last updated in commit 8501bedd7508ac514385806e191aec21ee978891 (tree 1b6c31139a71f80245c09597c343936a8e41d021)
GOOD
src/leveldb in HEAD currently refers to tree cb176f0f0a9a93bcef89bdd70424cae01ad21629
src/leveldb in HEAD was last updated in commit a37778d4d32b4ddeff96f68a130dc8da3a84b278 (tree cb176f0f0a9a93bcef89bdd70424cae01ad21629)
GOOD
src/minisketch in HEAD currently refers to tree 85cb93120ae68ef1f6fa597da30e18298848e0e9
src/minisketch in HEAD was last updated in commit cb59af38e72ab189b052ec84e2d1027473235ba4 (tree 85cb93120ae68ef1f6fa597da30e18298848e0e9)
GOOD
src/secp256k1 in HEAD currently refers to tree 8664fa7a12899d879cab995b49d9457b22accf9d
src/secp256k1 in HEAD was last updated in commit 611562806cf3fd3028e24e6c5a8e8dcb8805be38 (tree 8664fa7a12899d879cab995b49d9457b22accf9d)
GOOD
src/common/sockman.h seems to be missing the expected include guard:
  #ifndef BITCOIN_COMMON_SOCKMAN_H
  #define BITCOIN_COMMON_SOCKMAN_H
  ...
  #endif // BITCOIN_COMMON_SOCKMAN_H

^---- ⚠️ Failure generated from lint-include-guards.py
src/ipc/protocol.h:57: neccessary ==> necessary
src/pow.cpp:138: signficant ==> significant
^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/spelling.ignore-words.txt
The locale dependent function fprintf(...) appears to be used:
src/sv2/connman.cpp:    fprintf(stderr, "Got %d bytes from client\n", n);
src/sv2/connman.h:        EXCLUSIVE_LOCKS_REQUIRED(!m_clients_mutex) { fprintf(stderr, "EventGotEOF\n"); }; // TODO in sv2/conmman.cpp
src/sv2/connman.h:        EXCLUSIVE_LOCKS_REQUIRED(!m_clients_mutex) { fprintf(stderr, "EventGotPermanentReadError\n"); }; // TODO in sv2/conmman.cpp

Unnecessary locale dependence can cause bugs that are very tricky to isolate and fix. Please avoid using locale-dependent functions if possible.

Advice not applicable in this specific case? Add an exception by updating the ignore list in /tmp/cirrus-ci-build/test/lint/lint-locale-dependence.py
^---- ⚠️ Failure generated from lint-locale-dependence.py
Success: no issues found in 300 source files

^---- ⚠️ Failure generated from lint check 'all_python_linters'!
Run all linters of the form: test/lint/lint-*.py
��������������������������������������������������������������������������������������������