rpc: default_witness_commitment is not optional

As of a806647 the commitment is never empty.
Sjors · Aug 21, 2023 · 8e1d13f · 8e1d13f
1 parent 36f62c5
commit 8e1d13f
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/src/rpc/mining.cpp b/src/rpc/mining.cpp
@@ -631,7 +631,7 @@ static RPCHelpMan getblocktemplate()
                 {RPCResult::Type::STR, "bits", "compressed target of next block"},
                 {RPCResult::Type::NUM, "height", "The height of the next block"},
                 {RPCResult::Type::STR_HEX, "signet_challenge", /*optional=*/true, "Only on signet"},
-                {RPCResult::Type::STR_HEX, "default_witness_commitment", /*optional=*/true, "a valid witness commitment for the unmodified block template"},
+                {RPCResult::Type::STR_HEX, "default_witness_commitment", "a valid witness commitment for the unmodified block template"},
             }},
         },
         RPCExamples{
@@ -948,9 +948,7 @@ static RPCHelpMan getblocktemplate()
         result.pushKV("signet_challenge", HexStr(consensusParams.signet_challenge));
     }
 
-    if (!pblocktemplate->vchCoinbaseCommitment.empty()) {
-        result.pushKV("default_witness_commitment", HexStr(pblocktemplate->vchCoinbaseCommitment));
-    }
+    result.pushKV("default_witness_commitment", HexStr(pblocktemplate->vchCoinbaseCommitment));
 
     return result;
 },