ALS Refactored with Smooth Sync

[emrehan98]

Hey, Sixze.

I've been trying to implement Smooth Sync with ALS Refactored. Smooth Sync is a plugin that simply smooths player location over network so even in extreme movements, such as climbing, flying etc. it gives you very smooth results over other clients and server with no effort so you don't really worry about custom movement and jittering problems.

But in order to make it work, you need to disable "Replicate Movement".

When I disable "Replicate Movement", ALS Refactored still functions pretty well but one thing that doesn't work is turn-in-place and I couldn't find the reason. I implemented my own variable to fix that problem but it wasn't the perfect solution as the result was jittery. (Animations are jittering, not the rotation.) I'm not CPP programmer, I can just read the code and make sense of it, do some little stuff so my solution is obviously not the best one.

OTVCeggxtL.mp4

Here's what I did.

ILge0SLRIl.mp4

I guess when I disable "Replicate Movement", ViewRotation no longer replicated in other clients so only owner can see animations work properly. I'm not sure if it's out of scope but it would be a huge help to make ViewRotation "Replicate Movement" independent so I could use both plugins. But if you can point me a direction that would be amazing too.

[emrehan98]

I made it work, so the problem was not using IsLocallyControlled. I thought (GetLocalRole() >= ROLE_AutonomousProxy) doing the same job but I was wrong.

So I discarded everything again, returned back to original ALS Refactored.

1 - I added "Server, Unreliable" to "SetViewRotation" in AlsCharacter.h
2 - Added "_Implementation" to end of the "SetViewRotation" in AlsCharacter.cpp.
3 - I changed the RefreshView function.

Now head rotations and turn in place works properly.

[Sixze]

I do not replicate the view rotation directly from client to server because the movement component already does it itself, but it looks like when the movement is not replicated, the view rotation is not replicated either.

The best option would be to rely on the replication of the movement component when bReplicateMovement == true, and, on the other hand, manually invoke the RPC as you do when bReplicateMovement == false.

I'll fix it soon in future commit.

[Sixze]

Fixed in 1920132.

[emrehan98]

Thank you so much!