fix(simulationcraft): cleanup of simulationcraft APL translator #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the condition code for Pulverize from an explicit condition in the script to a spell requirement. Fix the condition code to check for at least 2 stacks of Thrash instead of the ancient mechanic of simply needing the Thrash debuff to be on the target.
Enhanced Rejuvenation for guardian druids was removed from the game in Legion.
The feral druid Bloodtalons talent was changed in Shadowlands and no longer procs from casting Regrowth.
Kill Command requires that the hunter's pet be present and free to attack the target. Move the condition from an explicit check in the script to a spell requirement.
Arcane Brilliance was removed from the game a while ago, and will no longer be encountered as "arcane_brilliance" in an APL.
Frost mages can't cast Summon Water Elemental if a pet is already pre-existing. Move the condition check from an explicit check in the mage script to a spell requirement.
Monk's Nimble Brew was removed from the game a while ago, and will no longer be encountered as "nimble_brew" in an APL.
…usable Monk's Whirling Dragon Punch can only be cast when both Fists of Fury and Rising Sun Kick are on cooldown. Move the condition to check this from the script into a spell requirement.
Rogue Premeditation was changed a while back to be a buff you gain from entering Stealth, not a spell you use out of combat to gain combo points. Remove the translation for the premeditation action.
Shaman's Magma Totem was removed from the game a while ago. Remove the translation for magma_totem.
Warrior Commanding Shout was removed from the game a while ago. Remove the translation of commanding_shout.
Warrior Enraged Regeneration was changed a while ago to only be usable by Fury warriors and no longer grants health. Remove the special condition to check for missing health when translating enraged_regeneration.
Warrior Heroic Charge was removed from the game a while ago. Remove the translation for the heroic_charge action.
Stance-dancing is not available in SimulationCraft or in-game. Remove the translation for the 'stance' action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move some conditions from
states/emiter.tsto the class-specificspell script as spell requirements instead. This reduces the
complexity of the translator and puts class knowledge where you
would expect it to be.
Also remove outdated translations for actions that are no longer
available.