Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check for correct buffs on pets #786

Merged
merged 3 commits into from
Jan 4, 2021
Merged

fix: check for correct buffs on pets #786

merged 3 commits into from
Jan 4, 2021

Conversation

johnnylam88
Copy link
Contributor

This pullup fixes the spell ID for BM hunter pet Frenzy buff and
modifies simulationcraft/emiter.ts so that it translates the
following correctly:

  • buff.dark_transformation.
  • buff.beast_cleave.
  • buff.frenzy.

@johnnylam88
fix(emiter): some buffs must be checked on the pet, not the player
733ad19 
Dark Transformation (unholy DK) and Beast Cleave (BM hunter) are
buffs that need to be checked on the pet, not the player. Fix the
names of the buffs that are checked within EmitOperandBuff() that
trigger redirecting the target from "target" to "pet".
@johnnylam88
fix(hunter): fix pet Frenzy buff detection for hunters
3a2d0f7 
Use the correct spell ID for the pet Frenzy buff applied by Barbed
Shot and check for the buff on the pet, not on the player.
@johnnylam88
fix(scripts): regenerate deathknight and hunter scripts
1727f03 
Regenerate death knight and hunter scripts for the pet buff changes
for Dark Transformation, Beast Cleave, and Frenzy.
@johnnylam88 johnnylam88 changed the title check for correct buffs on pets fix: check for correct buffs on pets Jan 3, 2021
@Sidoine Sidoine merged commit 1d0c864 into Sidoine:master Jan 4, 2021
@johnnylam88 johnnylam88 deleted the fix/simc-pet-buffs branch January 4, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnnylam88 @Sidoine