Check for time to Runes when computing Time to Power. #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit 18d7714 did not correctly handle the optional extraPower paramter of Power:TimeToPower(). Generalize the parameter to be table whose keys "extra_energy" and "extra_focus" are checked for extra amounts of the power type when calculating the number of seconds until that power threshold is met. This removes the need to infer the pooled resource/power type.
getTimeToPowerat() is a state method that returns the number of seconds until a power level is reached for the given power type.
Save needing to use a constant definition for INFINITY by directly importing 'huge' as INFINITY, and use in place of 'huge' in conditions.
Use getTimeToPowerAt() to determine the number of seconds until a power level is reached instead of repeating the same code with minor differences in the return type.
Move Power:getTimetoPowerStateAt() to Spells:TimeToPowerForSpell() and change all references from the old function to the new one. Spells:TimeToPowerForSpell() also replaces Power:TimeToPower(). Remove unused Power functions TimeToPower() and hasPowerFor().
Runes are a type of power, so check that rune requirements are met in Spells:TimeToPowerForSpell(). Remove runes check from BestAction module since it is now encapsulated within Spells:TimeToPowerForSpell().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.