Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

desired_targets translation #236

Open
Hemario opened this issue Jan 26, 2017 · 4 comments
Open

desired_targets translation #236

Hemario opened this issue Jan 26, 2017 · 4 comments
Labels
enhancement

Comments

@Hemario
Copy link
Contributor

Hemario commented Jan 26, 2017

Based on the answer from simc: simulationcraft/simc#3423
Right now desired_targets is translated into Enemies(tagged=1). From what I understand it is the amount of enemies we have damaged already.
However, this does not seem to correspond to the actual meaning of desired_targets.

2 options:

  • count the amount "boss" units (which are hostile); but what if they are spread out?
  • hardcode it to 1

Any other options?
@ShmooDude
Copy link
Contributor

  • an option in the GUI.

I actually just made a drop down box manually in the feral script. There's not really a good way to do it. Which scripts actually use it?

@Hemario
Copy link
Contributor Author

Hemario commented Feb 2, 2017

a quick search in all the simulationcraft scripts:

  • havoc demon hunter
  • feral druid
  • arms warrior
  • fury warrior

@johnnylam88
Copy link
Contributor

This should just be hardcoded to 1 in the default scripts.

@johnnylam88
Copy link
Contributor

Another possibility is to translate it to a custom function DesiredTargets() whose value is taken from a drop-down list created via AddListItem() and which defaults to 1. This would allow for some in-game customization of the value.

I would suggest the drop-down choices be 1, 2, or 3.

johnnylam88 referenced this issue in johnnylam88/Ovale Dec 27, 2020
@johnnylam88
feat(simulationcraft): improve meaning of "desired_targets"
9c1a7d8 
In SimulationCraft, "desired_targets" is the number of long-lived
enemies that exist for the duration of the fight, and is less than
or equal to "active_enemies", which is the total number of enemies
present. Instead of translating "desired_targets" into
"Enemies(tagged=1)", which is the number of active enemies that the
player has attacked, change it to a custom function that by default
returns 1, but can be modified by a dropdown menu option.

Currently, support 1, 2, or 3 desired targets.

Fixes issue #236.
@johnnylam88 johnnylam88 mentioned this issue Dec 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@johnnylam88 @Sidoine @ShmooDude @Hemario