fix: rewrite demon hunter modules to correctly handle state #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `DemonHunterDemonic` module doesn't have to gain or lose fake auras to correctly track Demonic in Shadowlands. Only add a Metamorphosis buff of the correct duration within the simulator if a Demonic trigger spell was cast, for either Havoc or Vengeance specializations.
Keep track of current sigils that are charging (before activation) and also keep track of sigils in the simulator that are charging due to a spell cast within the simulator. Don't look for an activation spell because if a sigil doesn't hit anything, then it'll never seem like it activated. Just assume that it will activate after the charging time has ended. Also add Elysian Decree to the sigils that are tracked.
Keep track of pending Soul Fragments that have not yet spawned and also keep track of the total number of Soul Fragments after spells have been cast within the simulator.
|
I just noticed a typo in one of these commits. I will fix and push a new change in this branch to fix the issue. |
|
This pullup should be ready to go. I've tested it in both Havoc and Vengeance specs on my demon hunter. As a side note, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The demon hunter modules were not handling state correctly. In a
state module, the module registers for events to track what is
currently happening "live" in-game, and updates the current state
of the game based on those events. A state module also implements
the
StateModuleinterface and does two things:resetState()is called.applySpell*()functions are called.
Lastly, script conditions that query information from state modules
should query that information from the simulator state, not the
current state.
Make these changes to the three demon hunter modules that track the
Demonic talent, sigils, and Soul Fragments, respectively.