-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidebar filters and sidebar tag badges don't co-exist #19
Comments
Hi @Fedduh, sadly I could not reproduce this issue. I've added the same sidebar filter config you're using on my local storybook instance on the Could you please share a repo where sidebar filters trigger the issue so I can investigate it? |
It was a bit of a hassle to setup a repo (my own repo is private). This is the stackblitz: If you run it (npm i && npm start) it will show the badge in the sidebar, and on top When you
Hope this helps you debugging. I could indeed not reproduce the issue in your main branch. (please ignore the node version warnings.. locally i do use node > v20. But i can't change the node version of Stackblitz) |
I suspect that Could you try to keep your // .storybook/manager.ts
import { addons } from '@storybook/manager-api'
import { renderLabel } from 'storybook-addon-tag-badges'
const filters = { /* ... */ };
addons.setConfig({
sidebar: {
filters,
renderLabel,
}
}) |
That indeed fixes it! Thanks :) |
Yay! Thanks for reporting back. I'll add a more explicit use case in the README so it's easier to spot. |
🎉 This issue has been resolved in version 1.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I had the same issue. I noticed that when removing my sidebar filters in manager.ts, it did show up.
I have a sidebar filter in manager.ts so it won't display my stories with tag 'chromatic-only'
manager.ts
import { addons } from '@storybook/manager-api';
Originally posted by @Fedduh in #15 (comment)
The text was updated successfully, but these errors were encountered: