Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

theme upload does nothing, after refactor PR, when given no filename args #176

Closed
chrisbutcher opened this issue Aug 17, 2016 · 2 comments
Closed

theme upload does nothing, after refactor PR, when given no filename args #176

chrisbutcher opened this issue Aug 17, 2016 · 2 comments
Assignees
@chrisbutcher
Labels
🐛 bug

Comments

@chrisbutcher
Copy link
Contributor

After 11f0837

Running theme upload does nothing, and prints no error message

image

cc: @cshold
@chrisbutcher chrisbutcher self-assigned this Aug 17, 2016
@chryton
Copy link
Contributor

chryton commented Aug 17, 2016

Can confirm this is happening on my local as well.

@chrisbutcher
Copy link
Contributor Author

Found the issue. This function should not have been removed in a previous attempt to refactor

themekit/commands/upload.go

Line 59 in e5b4b2a

func extractFilenames(options UploadOptions, filenames []string) []string {

@chrisbutcher chrisbutcher mentioned this issue Aug 17, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisbutcher chrisbutcher

Labels
🐛 bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrisbutcher @chryton