Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused template and JavaScript files? #1595

Closed
clupprich opened this issue Nov 25, 2022 · 0 comments · Fixed by #1611
Closed

Unused template and JavaScript files? #1595

clupprich opened this issue Nov 25, 2022 · 0 comments · Fixed by #1611
Labels

Comments

@clupprich
Copy link

Description

I'm trying to bootstrap a Shopify app with Rails 7 and propshaft (so no sprockets). While doing that, I noticed that some of the JS and template files seem to be unused. Here's an (for sure incomplete) list:

* app/views/shopify_app/sessions/enable_cookies.html.erb
* app/views/shopify_app/sessions/request_storage_access.html.erb
* app/views/shopify_app/sessions/top_level_interaction.html.erb
* app/views/shopify_app/shared/post_redirect_to_auth_shopify.html.erb

* app/assets/javascripts/shopify_app/enable_cookies.js
* app/assets/javascripts/shopify_app/itp_helper.js
* app/assets/javascripts/shopify_app/partition_cookies.js
* app/assets/javascripts/shopify_app/post_redirect.js
* app/assets/javascripts/shopify_app/request_storage_access.js
* app/assets/javascripts/shopify_app/storage_access_redirect.js
* app/assets/javascripts/shopify_app/storage_access.js
* app/assets/javascripts/shopify_app/top_level_interaction.js
* app/assets/javascripts/shopify_app/top_level.js

Maybe I'm missing something, but I'm not seeing actions defined for these session views/templates, which in return are referencing the JS files mentioned above. After removing those files, tests for the gem are still passing, so they can't be that important 😉

Are these leftovers? If so, I'm happy to contribute a PR to remove them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant