Add changeset and summary

Shopify · Feb 11, 2023 · 6f1ceef · 6f1ceef
1 parent 1d04fd7
commit 6f1ceef
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/.changeset/four-rivers-destroy.md b/.changeset/four-rivers-destroy.md
@@ -0,0 +1,5 @@
+---
+'@remote-ui/react': minor
+---
+
+Added missing `detachDeletedInstance` function to `@remote-ui/react/reconciler`. This function is invoked during React's clean up phase, so prior to this change you'd get an exception / broken app when a component is removed from the tree.
diff --git a/packages/react/CHANGELOG.md b/packages/react/CHANGELOG.md
@@ -8,6 +8,10 @@
 
 - [#191](https://github.com/Shopify/remote-ui/pull/191) [`77ba3da`](https://github.com/Shopify/remote-ui/commit/77ba3da217cb0e443e674afc058916ca25f5900e) Thanks [@lemonmade](https://github.com/lemonmade)! - Removed re-export of `@remote-ui/rpc`. If you need `retain` or `release`, import them directly from `@remote-ui/rpc` instead.
 
+### Patch Changes
+
+- Added missing `detachDeletedInstance` function to `@remote-ui/react/reconciler`. This function is invoked during React's clean up phase, so prior to this change you'd get an exception / broken app when a component is removed from the tree.
+
 ## 4.6.0
 
 ### Minor Changes

diff --git a/packages/react/src/tests/e2e.test.tsx b/packages/react/src/tests/e2e.test.tsx
@@ -857,7 +857,7 @@ describe('@remote-ui/react', () => {
     expect(appElement.innerHTML).toContain('bac');
   });
 
-  it('handles removal of components that have unmounted', () => {
+  it('handles removal & cleanup of unmounted components', () => {
     const receiver = createRemoteReceiver();
     const remoteRoot = createRemoteRoot(receiver.receive, {
       components: [RemoteImage, RemoteButton],