Accounts, Part 3 #65
Merged
Accounts, Part 3 #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplhomer
commented
Oct 11, 2022
|
|
||
| if (rootData?.cart?._data) { | ||
| return rootData?.cart?._data; | ||
| } | ||
|
|
||
| throw rootData?.cart |
There was a problem hiding this comment.
This crashes the app if there is no cart present, so I removed it. We should reconsider whether we want a "magic" hook like this in H2.0.
Comment on lines
+124
to
+125
| event.currentTarget.value.length && | ||
| !event.currentTarget.validity.valid |
There was a problem hiding this comment.
Prevents the error from showing up if the user hasn't had a god-dang chance to fill it out yet!!!
remcolakens
added a commit
to remcolakens/hydrogen
that referenced
this pull request
Jul 14, 2023
## Context Added basic `<Layout />` component for handling the `<Header />` and `<Footer />` logic. Included some refactoring of the remix components for a better structure/overview ## Changes - Changed the remix components folder structure for better overview - Fixed Storybook aliases - Fixed Storybook tailwind content path - Added new component for handling the` <Layout />` - Added basic `<Header />` component with logo only - Added `<Footer />` component in the styling from the CBT design - Add skip to content link ## Screenshot  ## Paperwork [SCH-24](https://codeinternetapplications.atlassian.net/browse/SCH-24) [SCH-25](https://codeinternetapplications.atlassian.net/browse/SCH-25) [SCH-26](https://codeinternetapplications.atlassian.net/browse/SCH-26) ## Checklist - [x] My code follows the style guidelines of this project - [x] I've performed a self-review of my own code - [x] I've added a changeset if this PR contains user-facing or noteworthy changes - [x] I've commented my code, particularly in hard-to-understand areas - [x] I've made corresponding changes to the documentation - [x] I've tested my code for breaking changes and added the corresponding footer in this PR if needed [SCH-24]: https://codeinternetapplications.atlassian.net/browse/SCH-24?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [SCH-25]: https://codeinternetapplications.atlassian.net/browse/SCH-25?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [SCH-26]: https://codeinternetapplications.atlassian.net/browse/SCH-26?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
frandiox
pushed a commit
that referenced
this pull request
Oct 4, 2023
Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.14.0 to 5.25.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.25.0/packages/parser)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds out the Address CRUD functionality, and refactors everything to share a single modal.
RE: #1