From b5d33b0f9647b930a7547ea441a8761d02158f21 Mon Sep 17 00:00:00 2001 From: Fran Dios Date: Tue, 16 Apr 2024 13:51:56 +0200 Subject: [PATCH] Fix --customer-account-push flag when no domain is set in .env --- packages/cli/src/lib/dev-shared.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/cli/src/lib/dev-shared.ts b/packages/cli/src/lib/dev-shared.ts index 9e54e0fd07..ae29b4f852 100644 --- a/packages/cli/src/lib/dev-shared.ts +++ b/packages/cli/src/lib/dev-shared.ts @@ -18,9 +18,10 @@ import {getGraphiQLUrl} from './graphiql-url.js'; export function isMockShop(envVariables: Record) { return ( - // We fallback to mock.shop if the env var is not set - !envVariables.PUBLIC_STORE_DOMAIN || - envVariables.PUBLIC_STORE_DOMAIN === 'mock.shop' + envVariables.PUBLIC_STORE_DOMAIN === 'mock.shop' || + // We fallback to mock.shop if the env var is falsy. + // When it's undefined, it might be overwritten by remote variables. + envVariables.PUBLIC_STORE_DOMAIN === '' ); }