-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setup:vite command #1778
Add setup:vite command #1778
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good. One thing I noticed is that after converting the skeleton template, the lint
command in that template fails.
Fixed 👍 |
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
Needs #1728
This adds a
h2 setup vite
command that transforms the current project to a Vite project.?url
to CSS imports.<LiveReload />
component.vite.config.js
.remix.config.js
.remix.env.d.ts
toenv.d.ts
(this seems to be the new convention in Remix<>Vite templates).server.ts
.package.json
to run the Vite commands.package.json
and installs them.To 🎩 :
templates/skeleton
and runh2 setup vite
, or generate a new project and run it there.I've updated how we import
favicon
in the skeleton to be more correct and also compatible with Vite (importing frompublic
didn't make sense).