Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image warnings #2703

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Fix image warnings #2703

merged 1 commit into from
Jan 13, 2025

Conversation

wizardlyhel
Copy link
Contributor

WHY are these changes introduced?

We have been getting these image size warnings from the skeleton template for the longest time.

Screenshot 2025-01-10 at 2 07 41 PM

WHAT is this pull request doing?

Fix that warning

HOW to test your changes?

  1. locally run the project
  2. navigate to /collections

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

Copy link
Contributor

shopify bot commented Jan 10, 2025

Oxygen deployed a preview of your hl-fix-image-warning branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
classic-remix ✅ Successful (Logs) Preview deployment Inspect deployment January 10, 202510:11 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment January 10, 202510:11 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment January 10, 202510:11 PM
metaobjects ✅ Successful (Logs) Preview deployment Inspect deployment January 10, 202510:11 PM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment January 10, 202510:11 PM

Learn more about Hydrogen's GitHub integration.

@wizardlyhel wizardlyhel merged commit 49156e9 into main Jan 13, 2025
11 checks passed
@wizardlyhel wizardlyhel deleted the hl-fix-image-warning branch January 13, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants