From e405fcd5222fb6f14fa07e59a1b0b795a68f5926 Mon Sep 17 00:00:00 2001 From: Sofia Matulis Date: Tue, 28 May 2024 14:21:12 -0400 Subject: [PATCH 1/4] Ensure variant id is converted to an integer --- assets/quick-order-list.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/assets/quick-order-list.js b/assets/quick-order-list.js index bd4e73948ef..e64adb92b9f 100644 --- a/assets/quick-order-list.js +++ b/assets/quick-order-list.js @@ -116,7 +116,7 @@ if (!customElements.get('quick-order-list')) { this.cartUpdateUnsubscriber = subscribe(PUB_SUB_EVENTS.cartUpdate, (event) => { const variantIds = []; this.querySelectorAll('.variant-item').forEach((item) => { - variantIds.push(item.dataset.variantId); + variantIds.push(parseInt(item.dataset.variantId)); }); if ( From 390db0b3415e32a795132c6f0a9cd7b9bb8b4b26 Mon Sep 17 00:00:00 2001 From: Sofia Matulis Date: Tue, 28 May 2024 14:43:23 -0400 Subject: [PATCH 2/4] Revert logic --- assets/quick-order-list.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/assets/quick-order-list.js b/assets/quick-order-list.js index e64adb92b9f..3ef055f23f7 100644 --- a/assets/quick-order-list.js +++ b/assets/quick-order-list.js @@ -118,10 +118,9 @@ if (!customElements.get('quick-order-list')) { this.querySelectorAll('.variant-item').forEach((item) => { variantIds.push(parseInt(item.dataset.variantId)); }); - if ( event.source === this.quickOrderListId || - (event.cartData.items && variantIds.some((element) => !event.cartData.items.includes(element))) + (event.cartData.items && event.cartData.items.some((element) => !variantIds.includes(element.variant_id))) ) { return; } From a13b5857081fe7e0d8ca9e44de8b51f70006e25e Mon Sep 17 00:00:00 2001 From: Sofia Matulis Date: Tue, 28 May 2024 15:33:19 -0400 Subject: [PATCH 3/4] Feedback --- assets/quick-order-list.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/assets/quick-order-list.js b/assets/quick-order-list.js index 3ef055f23f7..8de73b43c11 100644 --- a/assets/quick-order-list.js +++ b/assets/quick-order-list.js @@ -120,8 +120,9 @@ if (!customElements.get('quick-order-list')) { }); if ( event.source === this.quickOrderListId || - (event.cartData.items && event.cartData.items.some((element) => !variantIds.includes(element.variant_id))) + !event.cartData.items?.some((element) => variantIds.includes(element.variant_id)) ) { + console.log('should be mostly true'); return; } // If its another section that made the update From 481f33a30de529bf6bcd6bc01d0f2c5741579cc0 Mon Sep 17 00:00:00 2001 From: Sofia Matulis Date: Tue, 28 May 2024 15:34:59 -0400 Subject: [PATCH 4/4] remove console --- assets/quick-order-list.js | 1 - 1 file changed, 1 deletion(-) diff --git a/assets/quick-order-list.js b/assets/quick-order-list.js index 8de73b43c11..7a86fb3b014 100644 --- a/assets/quick-order-list.js +++ b/assets/quick-order-list.js @@ -122,7 +122,6 @@ if (!customElements.get('quick-order-list')) { event.source === this.quickOrderListId || !event.cartData.items?.some((element) => variantIds.includes(element.variant_id)) ) { - console.log('should be mostly true'); return; } // If its another section that made the update