From 0c670fe967ef82d2d07bd769e778b1cb87fe3715 Mon Sep 17 00:00:00 2001 From: Jason Date: Tue, 29 Aug 2023 21:54:56 +0900 Subject: [PATCH 1/4] =update link to latest cli repo for README.md and CONTRIBUTING.md --- .github/CONTRIBUTING.md | 4 ++-- README.md | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index ae400f0e4ff..a0dc45cd826 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -96,7 +96,7 @@ You can follow these steps to go from setting up a store to creating a pull requ >:information_source: We'll assume you're already set up with Git and GitHub (if you're not familiar with these, [start with these docs](https://docs.github.com/github/getting-started-with-github/quickstart/set-up-git)). 1. Set up a [development store](https://shopify.dev/themes/tools/development-stores) so you can test your code changes (assuming you don't already have a store). -2. Install the [Shopify CLI](https://github.com/Shopify/shopify-cli) by following [these steps](https://shopify.dev/themes/tools/cli/installation). +2. Install the [Shopify CLI](https://github.com/Shopify/cli) by following [these steps](https://shopify.dev/themes/tools/cli/installation). 3. Fork the repository, clone it and create a new branch: ```sh git clone git@github.com:your-username/dawn.git @@ -105,7 +105,7 @@ git checkout -b your-new-branch-name ``` 4. Launch a development server: ```sh -shopify theme serve +shopify theme dev ``` 5. Add your changes to the codebase. 6. Commit your changes: diff --git a/README.md b/README.md index dca149e5b6b..47ffacd1f49 100644 --- a/README.md +++ b/README.md @@ -53,9 +53,9 @@ There are a number of really useful tools that the Shopify Themes team uses duri ### Shopify CLI -[Shopify CLI](https://github.com/Shopify/shopify-cli) helps you build Shopify themes faster and is used to automate and enhance your local development workflow. It comes bundled with a suite of commands for developing Shopify themes—everything from working with themes on a Shopify store (e.g. creating, publishing, deleting themes) or launching a development server for local theme development. +[Shopify CLI](https://github.com/Shopify/cli) helps you build Shopify themes faster and is used to automate and enhance your local development workflow. It comes bundled with a suite of commands for developing Shopify themes—everything from working with themes on a Shopify store (e.g. creating, publishing, deleting themes) or launching a development server for local theme development. -You can follow this [quick start guide for theme developers](https://github.com/Shopify/shopify-cli#quick-start-guide-for-theme-developers) to get started. +You can follow this [quick start guide for theme developers](https://github.com/Shopify/cli#developing-apps-with-shopify-cli) to get started. ### Theme Check From 58b8bcb5def065d54167d01539467bf8f1dd2878 Mon Sep 17 00:00:00 2001 From: Jason Date: Tue, 29 Aug 2023 22:05:43 +0900 Subject: [PATCH 2/4] =update release-notes --- release-notes.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/release-notes.md b/release-notes.md index d4dc701125b..d166d6f3ce7 100644 --- a/release-notes.md +++ b/release-notes.md @@ -21,4 +21,5 @@ Dawn 11.0.0 introduces new customization options to the announcement bar, new an ### Fixes and improvements - We fixed a bug where text links were not styled properly in the heading of the Related products section. - We made light stylistic improvements to link styles, alignment and spacing for both the dropdown and mega menu types in the Header. -- We fixed a bug where the Footer would display extra white space when the “Show email signup” setting was left unchecked. \ No newline at end of file +- We fixed a bug where the Footer would display extra white space when the “Show email signup” setting was left unchecked. +- Better documentation for developers to contribute to the repo \ No newline at end of file From 6dcbec8b4e26775358763c636497f9c9ce240301 Mon Sep 17 00:00:00 2001 From: Jason Date: Tue, 29 Aug 2023 22:15:29 +0900 Subject: [PATCH 3/4] revert --- release-notes.md | 1 - 1 file changed, 1 deletion(-) diff --git a/release-notes.md b/release-notes.md index d166d6f3ce7..0f79c0be0b4 100644 --- a/release-notes.md +++ b/release-notes.md @@ -22,4 +22,3 @@ Dawn 11.0.0 introduces new customization options to the announcement bar, new an - We fixed a bug where text links were not styled properly in the heading of the Related products section. - We made light stylistic improvements to link styles, alignment and spacing for both the dropdown and mega menu types in the Header. - We fixed a bug where the Footer would display extra white space when the “Show email signup” setting was left unchecked. -- Better documentation for developers to contribute to the repo \ No newline at end of file From d770fbeb9308e8838377ef18b7a215566b3b255f Mon Sep 17 00:00:00 2001 From: Jason Date: Tue, 29 Aug 2023 22:16:19 +0900 Subject: [PATCH 4/4] revert --- release-notes.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/release-notes.md b/release-notes.md index 0f79c0be0b4..d4dc701125b 100644 --- a/release-notes.md +++ b/release-notes.md @@ -21,4 +21,4 @@ Dawn 11.0.0 introduces new customization options to the announcement bar, new an ### Fixes and improvements - We fixed a bug where text links were not styled properly in the heading of the Related products section. - We made light stylistic improvements to link styles, alignment and spacing for both the dropdown and mega menu types in the Header. -- We fixed a bug where the Footer would display extra white space when the “Show email signup” setting was left unchecked. +- We fixed a bug where the Footer would display extra white space when the “Show email signup” setting was left unchecked. \ No newline at end of file