From 7530d2e39912745ca5a036d96279566edaa00e25 Mon Sep 17 00:00:00 2001 From: Baldur Helgason Date: Sun, 30 Jan 2022 10:43:54 +0000 Subject: [PATCH 1/3] Make sure first image is not lazy loaded --- sections/main-product.liquid | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sections/main-product.liquid b/sections/main-product.liquid index c791b71fec0..25134b79d75 100644 --- a/sections/main-product.liquid +++ b/sections/main-product.liquid @@ -68,7 +68,11 @@ {%- unless media.id == product.selected_or_first_available_variant.featured_media.id -%}
  • {%- assign media_position = media_position | default: 0 | plus: 1 -%} - {% render 'product-thumbnail', media: media, position: media_position, loop: section.settings.enable_video_looping, modal_id: section.id, xr_button: true, media_width: media_width, lazy_load: true %} + {%- assign lazy_load = false -%} + {%- if media_position > 1 -%} + {%- assign lazy_load = true -%} + {%- endif -%} + {% render 'product-thumbnail', media: media, position: media_position, loop: section.settings.enable_video_looping, modal_id: section.id, xr_button: true, media_width: media_width, lazy_load: lazy_load %}
  • {%- endunless -%} {%- endfor -%} From c06c5ad4a768aea3ff27e683fb3e36521829f882 Mon Sep 17 00:00:00 2001 From: Baldur Helgason Date: Fri, 4 Mar 2022 20:50:34 +0000 Subject: [PATCH 2/3] Use a single liquid tag --- sections/main-product.liquid | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/sections/main-product.liquid b/sections/main-product.liquid index 25134b79d75..d47682fe628 100644 --- a/sections/main-product.liquid +++ b/sections/main-product.liquid @@ -67,12 +67,14 @@ {%- for media in product.media -%} {%- unless media.id == product.selected_or_first_available_variant.featured_media.id -%}
  • - {%- assign media_position = media_position | default: 0 | plus: 1 -%} - {%- assign lazy_load = false -%} - {%- if media_position > 1 -%} - {%- assign lazy_load = true -%} - {%- endif -%} - {% render 'product-thumbnail', media: media, position: media_position, loop: section.settings.enable_video_looping, modal_id: section.id, xr_button: true, media_width: media_width, lazy_load: lazy_load %} + {% liquid + assign media_position = media_position | default: 0 | plus: 1 + assign lazy_load = false + if media_position > 1 + assign lazy_load = true + endif + render 'product-thumbnail', media: media, position: media_position, loop: section.settings.enable_video_looping, modal_id: section.id, xr_button: true, media_width: media_width, lazy_load: lazy_load + %}
  • {%- endunless -%} {%- endfor -%} From 6c2469e1acd27a0ec4061ec38ebf0385b070dc30 Mon Sep 17 00:00:00 2001 From: Baldur Helgason Date: Thu, 31 Mar 2022 19:30:11 +0000 Subject: [PATCH 3/3] Update sections/main-product.liquid Co-authored-by: Andrew Etchen --- sections/main-product.liquid | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sections/main-product.liquid b/sections/main-product.liquid index d47682fe628..0b79c20d41c 100644 --- a/sections/main-product.liquid +++ b/sections/main-product.liquid @@ -67,14 +67,14 @@ {%- for media in product.media -%} {%- unless media.id == product.selected_or_first_available_variant.featured_media.id -%}
  • - {% liquid + {%- liquid assign media_position = media_position | default: 0 | plus: 1 assign lazy_load = false if media_position > 1 assign lazy_load = true endif render 'product-thumbnail', media: media, position: media_position, loop: section.settings.enable_video_looping, modal_id: section.id, xr_button: true, media_width: media_width, lazy_load: lazy_load - %} + -%}
  • {%- endunless -%} {%- endfor -%}