-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sections to customer pages #543
Comments
HI @tyleralsbury, We are providing a Subscription App on Shopify App Store. I think this feature sounds good! UX is better for customers. For now, We need to avoid showing a customer portal on the account page. On developer docs,
Ref: https://shopify.dev/apps/subscriptions/customer-portal#liquid-code-in-the-shop-s-theme Also,
Ref: https://shopify.dev/apps/subscriptions/customer-portal#1-expose-an-action-to-send-an-email If we can use the feature secure, We'd like to create a theme extension for the customer portal! |
Thanks for the comment, @camelmasa . This proposal isn't really going to address those security concerns, unfortunately. It's simply to allow the option for app developers to use those sections to provide Liquid installation instructions without the need to edit theme files. Given the risks associated with doing this, we are still not recommending it until those can be addressed. |
#654 duplicates this. With regards to the login we need it to display extra information. Many customers do NOT understand they need to create an account. So we added an ugly warning: https://fammesportswear.com/account/login Which could more easily be made nicer with sections @tyleralsbury |
I've updated the issue to include |
I'd love to see this happen. I'm currently trying to convert the customer/account page myself but I'm not good at it and running into issues 😇 |
I've tried two other 2.0 themes that allow you to add app blocks to account pages but they have the same behaviour that I see when converting the customer/account page myself. Custom theme app extension |
This was due to an issue in the Theme Editor and is since resolved. Additionally, I've noticed that as of recently you get an issue in the code editor inside the Shopify Admin when you try to create an account template with JSON. |
Describe the enhancement you'd like
Allow the customer templates to have sections added to them. The following templates would be affected:
Along with the general benefits of having sections in more places, this would also allow merchants to add a custom Liquid section onto the page, which would allow for apps to be integrated onto those pages without the need for code edits. Some potential types of apps that would benefit from this include subscriptions as well as loyalty program apps.
Describe alternatives you've considered
The following templates could also be converted, but the value of having sections on them is much lower since they are much more action focused templates:
The text was updated successfully, but these errors were encountered: