Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Price Filter: Does not take into consideration current filters #3632

Open
ramadanomar opened this issue Sep 30, 2024 · 1 comment
Open

Price Filter: Does not take into consideration current filters #3632

ramadanomar opened this issue Sep 30, 2024 · 1 comment

Comments

@ramadanomar
Copy link

Describe the current behavior

The range-max is based on the whole collection instead of stacking with current active filters.

Example: Max price in /nike collection is 34,950

Adding some filters that would limit to only a single product still keeps the max range in the filter the same:
Image

Adding a minimum price filter would make it go out of bounds a lot of times
Image

Describe the expected behavior

As a user i'd expect it to take into account my current filters. Ex: If i'm searching for items of a specific type, i want ot be able to filter the prices based on that item type instead of whole collection.

Version information (Dawn, browsers and operating systems)

  • Dawn Version: Latest main branch commit (15.1.0 release)
  • Chrome Version 129.0.6668.70

Possible solution

Not sure if filter.range_max is stackable with other filters. If it's not then we should use JS to get lowest priced item. Could be a bit troublesome for infinite scrolling layouts.

@ramadanomar
Copy link
Author

If this is not the desired behaviour i can work on submitting a PR to adjust the behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant