Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shopify Subscription App error on Dawn theme 15.0.2 #3588

Closed
drewlonious opened this issue Aug 15, 2024 · 2 comments
Closed

Shopify Subscription App error on Dawn theme 15.0.2 #3588

drewlonious opened this issue Aug 15, 2024 · 2 comments

Comments

@drewlonious
Copy link

drewlonious commented Aug 15, 2024

Describe the current behavior

on load...
app-embed-block.js:320 Uncaught TypeError: Cannot read properties of null (reading 'querySelector') at updatePriceAndSellingPlanInfo (app-embed-block.js:320:44) at HTMLDocument.<anonymous> (app-embed-block.js:3:3)
Screenshot 2024-08-15 at 2 19 35 PM

when selecting different subscription plan options

app-embed-block.js:164 Uncaught TypeError: Cannot set properties of null (setting 'checked') at app-embed-block.js:164:21 at Array.forEach (<anonymous>) at selectSellingPlanAndGroupRadios (app-embed-block.js:163:17) at handleRadioButtonChange (app-embed-block.js:137:5) at HTMLInputElement.<anonymous> (app-embed-block.js:12:7)
Screenshot 2024-08-15 at 2 14 53 PM

Screenshot 2024-08-15 at 2 19 44 PM

Describe the expected behavior

It shouldn't be throwing errors when null

Version information (Dawn, browsers and operating systems)

  • Dawn Version: 15.0.2
  • Chrome Version 27.0.6533.100 (Official Build) (arm64)
  • macOS Version 14.5

Possible solution

Additional context/screenshots

on load
Screenshot 2024-08-15 at 2 16 04 PM

on selling plan change
Screenshot 2024-08-15 at 2 20 05 PM

seems to go away when disabling subscription widget in "App embeds" on theme customizer
Screenshot 2024-08-15 at 2 24 55 PM

@IlyaZha
Copy link

IlyaZha commented Aug 17, 2024

It was found out that the error occurs when a variant and a selling plan that does not include this variant are sent to the api.
Api in this case returns only ‘sections’ and JS throws an error.
@drewlonious Check/fix your selling plan

@drewlonious
Copy link
Author

@IlyaZha noted! thanks for the reply. i got it working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants