Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support shopify hosted video in video section #2247

Closed
kmeleta opened this issue Jan 23, 2023 · 3 comments · Fixed by #2248
Closed

Support shopify hosted video in video section #2247

kmeleta opened this issue Jan 23, 2023 · 3 comments · Fixed by #2248
Assignees

Comments

@kmeleta
Copy link
Contributor

kmeleta commented Jan 23, 2023

Add support for shopify hosted video (via video setting type) to existing video section.

https://www.figma.com/file/hQiYDulTbQCKxBqIbtCpWZ/Multirow-and-Shopify-hosted-video-explorations?node-id=610%3A23896&t=u195pyrwPwLIjTFE-0

Edit: Updated settings content

@kmeleta kmeleta self-assigned this Jan 23, 2023
@kmeleta kmeleta changed the title Video Section Build Support shopify hosted video in video section Jan 23, 2023
@bredowmax
Copy link
Contributor

May be related to #1687

@danielvan
Copy link
Contributor

@kmeleta, we had some feedback around the settings order and definition here. I've built an example image with the rationale behind the choices and our desired approach. Let me know if it works, or if you'd like align.

Image

cc @katycobb

@kmeleta
Copy link
Contributor Author

kmeleta commented Feb 14, 2023

Content decisions have changed. Aligned with Dan, Melissa, and Katy on these decisions (slack thread), at least until applicable bugs/behaviors in the video url setting are resolved.

Updated settings/content

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants