Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacing between main image and gallery controls #1653

Closed
YoannJailin opened this issue May 2, 2022 · 1 comment · Fixed by #1689
Closed

Spacing between main image and gallery controls #1653

YoannJailin opened this issue May 2, 2022 · 1 comment · Fixed by #1689
Assignees
Labels
Category: Bug Something isn't working

Comments

@YoannJailin
Copy link

YoannJailin commented May 2, 2022

Currently, i noticed that on my theme product page, spacing between main image and gallery controls is really high.

Capture d’écran, le 2022-05-02 à 16 03 27

Capture d’écran, le 2022-05-02 à 15 55 29

(By gallery controls, i mean slider controls or thumbnails slider)

Also, I went to check on other themes using Dawn in the theme store (Crave in this example) and noticed that this spacing is shorter there.

Capture d’écran, le 2022-05-02 à 15 55 37

I made sure in my test product that all images have the same ratio. Image sizes is different but the ratio if always square.

Version information (Dawn, browsers and operating systems)

  • Dawn Version: 5.0.0
  • Chrome Version 101.0.4951.41
  • macOS Version 11.3.
@bacounts
Copy link

bacounts commented May 3, 2022

Could this be addressed in a quick PR with #1652, or vice-versa?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants