Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product Template: Multi-Variant Product Featured Images (Without Specific Variant Images) are Lazy Loaded #1649

Closed
danklammer opened this issue Apr 29, 2022 · 2 comments

Comments

@danklammer
Copy link

The featured product image is lazy loaded on Product pages when:

  1. There are multiple variants
  2. Variants do not have specific images (They all share same images)

A good example of this is a PDP for Shoes (variants being the different sizes). This bug exists in Dawn Version 5.0.0.

I tried to fix the problem by including product.media.first within the If Statement but there are other things happening that I do not understand:
https://github.com/Shopify/dawn/blob/main/sections/main-product.liquid#L58-L64

@bacounts
Copy link

bacounts commented Apr 29, 2022

If I understand your issue, it appears it was fixed and merged yesterday using PR #1286.

This fix will be packed to the Shopify store in release 6.0 or via your GH upstream.

@danklammer
Copy link
Author

Fantastic! Thanks @bacounts and Team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants