Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to cart button spinner is not displayed in Safari #1589

Closed
KaichenWang opened this issue Apr 5, 2022 · 2 comments
Closed

Add to cart button spinner is not displayed in Safari #1589

KaichenWang opened this issue Apr 5, 2022 · 2 comments
Labels
Category: Bug Something isn't working

Comments

@KaichenWang
Copy link
Contributor

Describe the current behavior

When a custom clicks the add to cart button in Safari, the add to cart button goes blank and it looks like nothing is happening, then the button reverts to it's original state and an add to cart banner is displayed

Describe the expected behavior

When a customer clicks the add to cart button, the text in the button is replaced with a spinner to indicate the request is being processed and then afterwards the add to cart button is reverted to it's original state and an add to cart banner is displayed

Version information (Dawn, browsers and operating systems)

  • Dawn Version: 4.0.0
  • Safari 15.4 on MacOS (Catalina)
  • Safari 15.4 on iOS 15.4

Possible solution

Additional context/screenshots
Add any other context about the problem here. If applicable, add screenshots to help explain.

@KaichenWang KaichenWang added the Category: Bug Something isn't working label Apr 5, 2022
@mashkovtsevlx
Copy link
Contributor

I proposed a fix in #1646

@andrewetchen
Copy link
Contributor

Closing as this was fixed here: #1646

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants