Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text using opacity makes it tricky to keep an accessible contrast ratio #1521

Closed
ludoboludo opened this issue Mar 22, 2022 · 1 comment · May be fixed by #1539
Closed

Text using opacity makes it tricky to keep an accessible contrast ratio #1521

ludoboludo opened this issue Mar 22, 2022 · 1 comment · May be fixed by #1539
Assignees
Labels
Category: Accessibility Bugs found while using assistive technology Critical Path: 3 Affects few merchants/buyers Effort: Medium Severity: 4

Comments

@ludoboludo
Copy link
Contributor

Describe the current behavior

Currently we're relying on opacity to differentiate some pieces of information. We're applying a .75 opacity which can cause the color contrast between the text color and the background to be too low. The contrast ratio should be at 4.5 to be considered accessible.

We could change it so that it's using full opacity instead but we will need to check where it's been used and find alternative ways to have a visual hierarchy.
Here are some pros and cons to that switch:
👍 Some existing and new art directions will benefit aesthetically from all the text being 100% opacity
👍 The way colour works in our themes becomes more predictable
👍 Providing we select colours with enough contrast, we will meet accessibility standards.
👎 Some existing themes benefited from the hierarchy that the different opacity levels gave us, however, we can look at providing this as a setting, either through the colour work, or separately in the future.

Describe the expected behavior

Version information (Dawn, browsers and operating systems)

  • Dawn Version: 4.0.0

Possible solution
Remove the opacity in most places and rely on a different visual cue.

Additional context/screenshots
Add any other context about the problem here. If applicable, add screenshots to help explain.

cc: @allylane @nicklepine

@ludoboludo ludoboludo added the Category: Accessibility Bugs found while using assistive technology label Mar 22, 2022
@svinkle svinkle added Severity: 1 Urgent Severity Effort: Medium Critical Path: 1 Affects all merchants/buyers labels Mar 25, 2022
@ludoboludo ludoboludo mentioned this issue Mar 25, 2022
9 tasks
@ludoboludo ludoboludo self-assigned this Mar 28, 2022
@kimberlyoleiro kimberlyoleiro added Severity: 3 Normal/Low Severity Critical Path: 3 Affects few merchants/buyers Severity: 4 and removed Severity: 1 Urgent Severity Critical Path: 1 Affects all merchants/buyers Severity: 3 Normal/Low Severity labels May 18, 2023
@Stephanie-Chou
Copy link
Contributor

We are closing this issue. This issue was reported 2 years ago on an old version of Dawn. If this is still a high priority issue today, please re open with updated reproduction steps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Accessibility Bugs found while using assistive technology Critical Path: 3 Affects few merchants/buyers Effort: Medium Severity: 4
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants