Slider Component: Box shadow on elements within a slider can get cut off

[nicklepine]

Box shadow on elements within a slider can get cut off

[melissaperreault]

This is interesting because @kmeleta and I did had a fix for this not so long ago, seems like it was reintroduced. I also noticed another odd thing:

• Featured collection: When Cards style are set to Standard + have positive vertical shadow offset with blur, the space below the cards is increased and it is not as appealing like it can be for the style Cards. Looks like a bug and that it has too much negative space. (Video reference)

[kmeleta]

• Featured collection: When Cards style are set to Standard + have positive vertical shadow offset with blur, the space below the cards is increased and it is not as appealing like it can be for the style Cards. Looks like a bug and that it has too much negative space. (Video reference)

@melissaperreault would you consider this card specific issue to be sev 1? Or can it wait until we have more time to improve the shadow padding logic in general?

[nicklepine]

@melissaperreault @kmeleta a similar issue is happening on the checkout button on the cart template. Is it possible to address on the same PR?

I'm noticing that we don't have any padding below the checkout button on the cart page (as observed when adding a section like image banner underneath) . Perhaps adding padding, or the top/bottom padding settings could help fix this.

[kmeleta]

Padding could certainly help if @melissaperreault wants to advise on a value. Otherwise if we didn't want to mess with padding, what you're seeing I think is more related to the PR that @sofiamatulis has up #1209. The background of the section below is covering the shadow of the checkout button because of the shadow's -1 z-index. We could probably add it to that as well. Thoughts?

[kmeleta]

Fix for the original severity 1 issue has been resolved in #1231. The standard card exception Meli mentioned is being handled in a follow up PR.

[melissaperreault]

Padding could certainly help if @melissaperreault wants to advise on a value.

The value should follow the same we applied for other sections, example

[melissaperreault]

Got reintroduced in some ways where we can still see the cut off:

• Here on video example
• Screenshot

cc. @danielvan