Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Brand microdata for a product - how to fix #1047

Closed
maofree opened this issue Dec 18, 2021 · 3 comments
Closed

Wrong Brand microdata for a product - how to fix #1047

maofree opened this issue Dec 18, 2021 · 3 comments

Comments

@maofree
Copy link

maofree commented Dec 18, 2021

Hi

Describe the current behavior
at this moment the product microdata about the brand is now more right
the type is equal to "Thing"

Describe the expected behavior
now it is necessary to be "Brand"

Version information (Dawn, browsers and operating systems)

  • Dawn Version: 2.4.0

Additional context/screenshots
2

can you say me where is the file to fix this problem?

can you say me how I can update the dawn version to the last one?
is it necessary to download the last version from github and the upload it from shopify ?

thanks

@maofree
Copy link
Author

maofree commented Dec 18, 2021

3

I've also updated to 2.5.0

why shopify doesn't use a child theme? should be much better to take updated all themes

@Atron100
Copy link

Atron100 commented Jan 9, 2022

also the all schematic must be updated , aggregatedRating and review must be added to json schematic. because google will not add products without these fields in enhancement. all shopify apps not compatible with this dawn theme.

after "sku": - row under "offers"

i will suggest to add also
"mpn": {{ variant.barcode | json }},

@andrewetchen
Copy link
Contributor

Hi @maofree 👋🏼

Thanks for your help. I'm going to close this PR as it has been fixed and reviewed here: #1600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants