Fix compatibility with Minitest 5.19+ #452
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `MiniTest` was renamed to `Minitest`: minitest/minitest@9a57c52 And the `MiniTest` constant is now loaded just when `MT_COMPAT` environment variable is set: minitest/minitest@a2c6c18
|
As always, I cannot sign the CLA, so do whatever you need to do with this PR (and I would not mind if you dropped the CLA) |
|
The CLA annoys me as much as you but unfortunately my hands are tied. The test suite doesn't pass anyway, so I'll consider this PR as a bug report and fix it myself. Thanks. |
|
And this also needs Mocha 2.1+ if I am not mistaken |
|
Fixed in b75c683 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MiniTestwas renamed toMinitest:minitest/minitest@9a57c52
And the
MiniTestconstant is now loaded just whenMT_COMPATenvironment variable is set:minitest/minitest@a2c6c18