Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum watermark length is only 9 characters! #8

Open
exo-pla-net opened this issue Aug 30, 2022 · 3 comments
Open

Maximum watermark length is only 9 characters! #8

exo-pla-net opened this issue Aug 30, 2022 · 3 comments

Comments

@exo-pla-net
Copy link

You can't encode much of a watermark with only 9 characters.

This limitation should be specified in the README.

@exo-pla-net
Copy link
Author

For anyone landing here, wanting to hide more than 9 characters, I wrote this code to hide any object in an image as an invisible watermark:
https://gist.github.com/exo-pla-net/c3ad83034ca15e60af6d592e749aab56

@loretoparisi
Copy link

For anyone landing here, wanting to hide more than 9 characters, I wrote this code to hide any object in an image as an invisible watermark:

https://gist.github.com/exo-pla-net/c3ad83034ca15e60af6d592e749aab56

That's super cool! Did you test as replacement to this invisible-watermark in CompVis script?

@muhqu
Copy link

muhqu commented Sep 5, 2022

@exo-pla-net Nice script!

But please note that it uses the pickle module for encoding/decoding which can lead to security issues.

From Python docs:

Warning: The pickle module is not secure. Only unpickle data you trust.
It is possible to construct malicious pickle data which will execute arbitrary code during unpickling. Never unpickle data that could have come from an untrusted source, or that could have been tampered with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants