Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review comments #1

Open
KAClough opened this issue Apr 15, 2024 · 1 comment
Open

Review comments #1

KAClough opened this issue Apr 15, 2024 · 1 comment
Assignees
@ShaunFell

Comments

@KAClough
Copy link

I'll add some comments here, overall it looks great, but I can make some stylistic suggestions.
@ShaunFell ShaunFell assigned KAClough and ShaunFell and unassigned KAClough Apr 15, 2024
@ShaunFell
Copy link
Owner

Hi @KAClough!

I opened PR #20 for making GRDzhadzha a dependency. I rebuilt some things and all the examples and tests run. Feel free to make yourself a reviewer (if you can?) and let me know your thoughts. We can discuss further details at the conference next week as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShaunFell ShaunFell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KAClough @ShaunFell