Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for very old versions of setuptools #84

Merged
merged 1 commit into from
Nov 18, 2018

Conversation

SethMMorton
Copy link
Owner

The syntax "fastnumbers >= 2.0.0; python_version > 2.6" is "new" in the
sense that there are still OSs (like CentOS) that use still have
setuptools versions installed that do not support it.

The solution is to selectively add the dependency using logic rather
than declaratively.

This will solve issue #64.

The syntax "fastnumbers >= 2.0.0; python_version > 2.6" is "new" in the
sense that there are still OSs (like CentOS) that use still have
setuptools versions installed that do not support it.

The solution is to selectively add the dependency using logic rather
than declaratively.

This will solve issue #64.
@codecov
Copy link

codecov bot commented Nov 18, 2018

Codecov Report

Merging #84 into master will decrease coverage by 8.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #84     +/-   ##
=========================================
- Coverage   99.52%   91.22%   -8.3%     
=========================================
  Files          12       12             
  Lines         627      627             
=========================================
- Hits          624      572     -52     
- Misses          3       55     +52
Impacted Files Coverage Δ
natsort/compat/locale.py 48.21% <0%> (-51.79%) ⬇️
natsort/compat/py23.py 79.54% <0%> (-13.64%) ⬇️
natsort/natsort.py 87% <0%> (-13%) ⬇️
natsort/compat/fastnumbers.py 87.5% <0%> (-12.5%) ⬇️
natsort/__init__.py 91.66% <0%> (-8.34%) ⬇️
natsort/utils.py 99.2% <0%> (-0.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d32e5a8...0276ed3. Read the comment docs.

@SethMMorton SethMMorton merged commit c38b366 into master Nov 18, 2018
@SethMMorton SethMMorton deleted the support-older-setuptools branch November 18, 2018 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant