Add support for ints and floats comprised of unicode decimal strings. #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tracebacks were just too long and it made debugging hard.
The regular expressions to separate numbers from non-numbers has been updated to accept more than just ASCII numbers.
The behavior of fake_fastnumbers was not matching that of fastnumbers, which was to allow conversion of strings such as "۱۲" to 12. This has been corrected.
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
+ Coverage 99.65% 99.65% +<.01%
==========================================
Files 10 10
Lines 574 581 +7
==========================================
+ Hits 572 579 +7
Misses 2 2
Continue to review full report at Codecov.
|
SethMMorton
deleted the
52-sorting-arabic-farsi-or-hebrew-numbers-is-not-natural
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to fully support all numbers that the built-in
intandfloatsupport, the regular expressions used to split input strings have been updated to support a wider variety of numbers.Accepting this will close #52.