-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pip install'ing v4.0.2 doesn't bring the compat directory #30
Comments
It also breaks https://github.com/FalconSocial/pre-commit-python-sorter, which is a fairly popular pre-commit hook (normally I hate the +1 comments, but...) |
I am not sure if this is the correct place. But perhabs it would be a good idea to add a tox env for check-manifest to check the files before pushing to PYPI. We used it in our company since some months and we are very happy with it. |
Oh man, sorry guys!!!!!!!!! I have just fixed this and released version 4.0.3, and have validated that this installs correctly. |
Yep, working great. Thanks so much! |
OH THANK GOD! Thanks for letting me know. I will definitely update my release procedure to avoid boo-boos like this. I 'm going to reopen and keep this open for a week or so in case someone updated in that 8 hour window but didn't run right away... then this issue will be easy to find. For reference, the update came in commit 03cc17b (tag v4.0.3), and is fixed in natsort version 4.0.3 on PyPI. |
natsort v4.0.2 installed with pip doesn't come with the compat directory, which then breaks running natsort:
The text was updated successfully, but these errors were encountered: