-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.8 #104
Conversation
One test is failing on Python 3.8:
|
I'm surprised that TravisCI supports Python 3.8 already... typically it takes them months to roll out support. |
Regarding the failing check, this is pretty expected. Each new Python version adds more Unicode support, and |
Travis was the first (of the CIs I've been checking) to add 3.8, in less than 24 hours! It took GitHub Actions 21 days, Azure Pipelines 25 days and AppVeyor 26 days. Thanks, will update the Unicode list when I'm next at a keyboard. |
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
=======================================
- Coverage 99.52% 95.52% -4%
=======================================
Files 10 10
Lines 425 425
=======================================
- Hits 423 406 -17
- Misses 2 19 +17
Continue to review full report at Codecov.
|
Updated! Python 3.8 passes.
|
Huh... from the message it looks like PyICU is not building. I'll take a look. |
Looks like PyICU made an update to 2.4 yesterday and compilation started breaking across all platforms. I filed this issue as well (ovalhub/pyicu#116), as our signature seems different from others. |
I'm going to merge this, because the failure is not related to your change. |
@SethMMorton can you release a new version with this change included? We're currently already in the middle of rebuilds for python3.8 on Arch Linux and I'd like to be able to drop the patch. |
@dvzrv Hmm... I was hoping to wait and release along with the drop of 2.7 support. Though, I suppose now is as good of a time as any to start the |
@dvzrv What's your timeline for wanting a release with this? |
@SethMMorton On some projects, I have Travis CI set up to auto-deploy to PyPI on tags, it makes releasing much easier. (It also auto-deploys to Test PyPI for merges to master.)
Let me know if you'd like something similar. I'd be happy to create a PR and help you set it up. It uses encrypted API tokens for upload: https://pypi.org/help/#apitoken. |
On 2019-11-12 16:20:52 (-0800), Seth Morton wrote:
@dvzrv What's your timeline for wanting a release with this?
asap (but no stress) ;-)
The rebuilt packages for python3.8 are already in testing, but the
previous release (and also 6.1.0) require patching to be compatible with
python3.8.
As the sources from pypi don't include certain files (e.g. .travis.yml),
that have been changed in the pull request, fixing this issue, the patch
doesn't apply cleanly.
|
@dvzrv I'll release today |
@hugovk Thank you for the suggestion. I actually had that set up many years ago but removed it because something went wrong (I don't remember what now). I would feel more comfortable if there were some sort of button I had to press in the CI to actually enact the deployment, because I am always afraid of accidentally releasing something broken. |
@dvzrv Released |
@hugovk I'm not opposed to the idea. I'd be interested in seeing the PR. |
Please see PR #106. |
On 2019-11-13 11:44:31 (-0800), Seth Morton wrote:
@dvzrv Released
Thank you! Works for me! :)
|
No description provided.