fix: improve @ mention parsing for GitHub usernames #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update regex to correctly identify valid GitHub usernames - Prevent false positives for package names and email addresses - Exclude matches within code snippets, URLs, and Markdown links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the @ mention parsing in the
convertMentionsToLinksfunction to more accurately identify valid GitHub usernames while avoiding false positives. This addresses the issue raised in #32.Key Changes
You can test the new regex pattern here: https://regex101.com/r/vBdvdh/1
This update ensures that only valid GitHub usernames are converted to profile links.
Current Behavior
The following screenshot shows how package names are incorrectly being converted to GitHub profile links in v1.15.1
After This Change
With this PR, package names will no longer be converted to links, resolving the issue shown above.