You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Workflows will never get triggered, and their status will remain in this state: Expected — Waiting for status to be reported .
Expected behavior
Workflows start after a team member approves the PR.
Vesion (please complete the following information):
N/A
Additional context
My guess would be that in the project settings, the branch protection rules is enabled. For a collaborator to be able to push in main, both the backend and frontend CI need to succeed.
Also, workflows on PR from outside contributors might not run automatically, and might need to be approved first. After being approved, the workflows will then get triggered.
However, both jobs only run on push. See pythonci.yml#L4 and webapp_ci.yml#L4. Since those PR come from forks, no push events can trigger the workflows and upon approval, workflows will not start since they only do for push events.
Assuming that this is reason of the issue, I think that adding the pull_request event to the workflow files might fix this issue. You might also want to add the pull_request_target event to trigger workflows (which will run in the context of the main branch) regardless of approval status.
Describe the bug
When a contributor submit a pull request from a fork, workflows do not run which prevents the PR to gets merged.
Here is an example: #620
To Reproduce
Workflows will never get triggered, and their status will remain in this state:
Expected — Waiting for status to be reported
.Expected behavior
Workflows start after a team member approves the PR.
Vesion (please complete the following information):
N/A
Additional context
My guess would be that in the project settings, the branch protection rules is enabled. For a collaborator to be able to push in main, both the backend and frontend CI need to succeed.
Also, workflows on PR from outside contributors might not run automatically, and might need to be approved first. After being approved, the workflows will then get triggered.
However, both jobs only run on push. See pythonci.yml#L4 and webapp_ci.yml#L4. Since those PR come from forks, no push events can trigger the workflows and upon approval, workflows will not start since they only do for push events.
Assuming that this is reason of the issue, I think that adding the pull_request event to the workflow files might fix this issue. You might also want to add the pull_request_target event to trigger workflows (which will run in the context of the main branch) regardless of approval status.
For the latter, you can have a look at Controlling changes from forks to workflows in public repositories.
The text was updated successfully, but these errors were encountered: