Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh #330 brave support #331

Merged

Conversation

aleksandr-kotlyar
Copy link
Collaborator

@aleksandr-kotlyar aleksandr-kotlyar commented Feb 28, 2022

Resolves #330
The main idea of @lhoggatt17 from PR #327

lhoggatt and others added 2 commits February 25, 2022 12:58
* fix gh SergeyPirogov#310 reverting string concatenation of windows script

* fix powershell determination logic and final windows command
@pep8speaks
Copy link

pep8speaks commented Feb 28, 2022

Hello @aleksandr-kotlyar! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 27:80: E501 line too long (82 > 79 characters)
Line 34:80: E501 line too long (83 > 79 characters)
Line 35:80: E501 line too long (105 > 79 characters)
Line 48:80: E501 line too long (84 > 79 characters)

Line 148:80: E501 line too long (108 > 79 characters)
Line 189:80: E501 line too long (116 > 79 characters)
Line 190:80: E501 line too long (100 > 79 characters)
Line 192:80: E501 line too long (130 > 79 characters)
Line 193:80: E501 line too long (136 > 79 characters)
Line 194:80: E501 line too long (130 > 79 characters)
Line 195:80: E501 line too long (115 > 79 characters)
Line 196:80: E501 line too long (160 > 79 characters)

Comment last updated at 2022-03-01 09:38:11 UTC

@aleksandr-kotlyar aleksandr-kotlyar force-pushed the gh_330_brave branch 2 times, most recently from 10460a1 to 4eeb003 Compare February 28, 2022 21:01
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2022

Codecov Report

Merging #331 (c351d1e) into master (acf72e0) will decrease coverage by 0.81%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #331      +/-   ##
==========================================
- Coverage   89.45%   88.64%   -0.82%     
==========================================
  Files          11       11              
  Lines         493      493              
  Branches       70       70              
==========================================
- Hits          441      437       -4     
- Misses         35       39       +4     
  Partials       17       17              
Impacted Files Coverage Δ
webdriver_manager/utils.py 78.18% <100.00%> (ø)
webdriver_manager/driver.py 93.75% <0.00%> (-2.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acf72e0...c351d1e. Read the comment docs.

binary_location = {
OSType.LINUX: "/usr/bin/brave-browser",
OSType.MAC: "/Applications/Brave Browser.app/Contents/MacOS/Brave Browser",
OSType.WIN: "$env:LOCALAPPDATA\\AppData\\Local\\BraveSoftware\\Brave-Browser\\Application",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test fails on Windows CI for now.
Need to fix this path for Github Actions and local installations - make it more universal.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@aleksandr-kotlyar aleksandr-kotlyar force-pushed the gh_330_brave branch 2 times, most recently from cda2b87 to bbbee46 Compare March 1, 2022 08:30
- adopt for brave beta and nightly channels for linux
- determine compatible chromedriver for Brave by browser's major version
- add selemium test for brave
- to snake_case naming of Brave test functions
- add Brave installation on Mac/Win/Linux in CI for selenium test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Brave browser
4 participants