-
-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh #330 brave support #331
gh #330 brave support #331
Conversation
* fix gh SergeyPirogov#310 reverting string concatenation of windows script * fix powershell determination logic and final windows command
Hello @aleksandr-kotlyar! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2022-03-01 09:38:11 UTC |
10460a1
to
4eeb003
Compare
Codecov Report
@@ Coverage Diff @@
## master #331 +/- ##
==========================================
- Coverage 89.45% 88.64% -0.82%
==========================================
Files 11 11
Lines 493 493
Branches 70 70
==========================================
- Hits 441 437 -4
- Misses 35 39 +4
Partials 17 17
Continue to review full report at Codecov.
|
4eeb003
to
aec5bcb
Compare
tests/test_brave_driver.py
Outdated
binary_location = { | ||
OSType.LINUX: "/usr/bin/brave-browser", | ||
OSType.MAC: "/Applications/Brave Browser.app/Contents/MacOS/Brave Browser", | ||
OSType.WIN: "$env:LOCALAPPDATA\\AppData\\Local\\BraveSoftware\\Brave-Browser\\Application", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test fails on Windows CI for now.
Need to fix this path for Github Actions and local installations - make it more universal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
cda2b87
to
bbbee46
Compare
- adopt for brave beta and nightly channels for linux - determine compatible chromedriver for Brave by browser's major version - add selemium test for brave - to snake_case naming of Brave test functions - add Brave installation on Mac/Win/Linux in CI for selenium test
bbbee46
to
51048e4
Compare
Resolves #330
The main idea of @lhoggatt17 from PR #327