fix: stdio problem when making exe using pyinstaller with noconsole flag

[HHongSeungWoo]

No description provided.

[pep8speaks]

Hello @HHongSeungWoo! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file webdriver_manager/utils.py:

Line 151:80: E501 line too long (107 > 79 characters)
Line 171:80: E501 line too long (107 > 79 characters)

[SergeyPirogov]

@HHongSeungWoo what problem we are solving by this?

[codecov-commenter]

Codecov Report

Merging #198 (5cd860d) into master (4169000) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #198      +/-   ##
==========================================
+ Coverage   88.49%   88.52%   +0.02%     
==========================================
  Files          11       11              
  Lines         452      453       +1     
  Branches       48       48              
==========================================
+ Hits          400      401       +1     
  Misses         35       35              
  Partials       17       17              

Impacted Files	Coverage Δ
webdriver_manager/utils.py	74.07% <100.00%> (+0.24%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4169000...5cd860d. Read the comment docs.

[HHongSeungWoo]

@SergeyPirogov
Test OS: windows, linux

In browser version check function, to get a version, this library uses os.popen.
os.popen uses subprocess.popen with stdin=None, and stderr=None.
But, If std* is set to None, subprocess.popen try to find std* from parents.
When using pyinstaller with --no-console in windows, parents do not have std*. So, It cause freezing.
pyinstaller source code

So, I replaced os.popen with subprocess.popen and set stderr and stdin to subprocess.DVENULL.

[rockyhuber]

Any idea how to make the console disappear? The original console is hidden, though now with these changes it opens another console. I have tried hundreds of variations to try to make it work, best I have been able to do is make the console disappear around 5s after.

cmd = cmd_mapping[browser_type][os_name()] version = None with subprocess.Popen(cmd, shell=False, creationflags=0x00000008, stdout=subprocess.PIPE, stderr=subprocess.DEVNULL, stdin=subprocess.DEVNULL) as stream: stdout = stream.communicate()[0].decode() version = re.search(pattern, stdout)

[HHongSeungWoo]

@rockyhuber i dont speak english well, but if you want hide consloe, try using creationflags=0x08000000