Revise the Raspberry Pi Pico sample implementation #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't read from an uninitiailized boolean variable. - Pull up the SCL and SDA pins used for I2C. - Use sleep_us for higher precision in the HAL. - Add error logging. - Increase precision of reported measurement data. - Remove lengthy sensor self-test. - Remove unused variables and functions. - Address any -Wall -Wextra warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using the SCD41 with a Raspberry Pi Pico W, and used this repository's sample implementation as a starting point.
The code in
sample-implementations/RaspberryPi_Pico/has several shortcomings that I aim to correct in this pull request:CMakeLists.txtto have the proper casing.main.c.main.c.This is my first time contributing to this project, so I'm happy to make any changes requested.