Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images from Ray Gervais's post are broken #774

Closed
c3ho opened this issue Mar 3, 2020 · 4 comments
Closed

Images from Ray Gervais's post are broken #774

c3ho opened this issue Mar 3, 2020 · 4 comments
Assignees
Labels
type: bug Something isn't working

Comments

@c3ho
Copy link
Contributor

c3ho commented Mar 3, 2020

What happened:
Images are not being rendered on dev for Ray Gervais's post

image

What should have happened:
Images should have been rendered

How to reproduce it (as precise as possible):
Go to the link above

Anything else we need to know?:
If you go to his blog, you will find images are actually fine and aren't broken

image

Environment:

  • OS: Windows 10
  • Browser: Chrome
@c3ho c3ho added the type: bug Something isn't working label Mar 3, 2020
@Silvyre
Copy link
Contributor

Silvyre commented Mar 3, 2020

@raygervais

@raygervais
Copy link
Contributor

I'm fairly confident this is on my side, since the references are relative path for my Gridsome site.

<img alt="Cover image" src="/assets/static/pawel-czerwinski-f_sUgtC7lV0-unsplash.07cc2b7.dc7372eb230e70039d4d363df4472818.jpg" data-src="/assets/static/pawel-czerwinski-f_sUgtC7lV0-unsplash.07cc2b7.dc7372eb230e70039d4d363df4472818.jpg" data-srcset="/assets/static/pawel-czerwinski-f_sUgtC7lV0-unsplash.a67b0b2.dc7372eb230e70039d4d363df4472818.jpg 480w, /assets/static/pawel-czerwinski-f_sUgtC7lV0-unsplash.07cc2b7.dc7372eb230e70039d4d363df4472818.jpg 860w" data-sizes="(max-width: 860px) 100vw, 860px" class="g-image g-image--lazy g-image--loaded" srcset="/assets/static/pawel-czerwinski-f_sUgtC7lV0-unsplash.a67b0b2.dc7372eb230e70039d4d363df4472818.jpg 480w, /assets/static/pawel-czerwinski-f_sUgtC7lV0-unsplash.07cc2b7.dc7372eb230e70039d4d363df4472818.jpg 860w" sizes="(max-width: 860px) 100vw, 860px" width="860"><noscript><img src="/assets/static/pawel-czerwinski-f_sUgtC7lV0-unsplash.07cc2b7.dc7372eb230e70039d4d363df4472818.jpg" class="g-image g-image--loaded" width="860" alt="Cover image"></noscript>

I will try using full path including URL to see if that fixes it on my end.

@raygervais
Copy link
Contributor

@Silvyre, I've opened up an issue with Gridsome (Vue alt of Gatsby essentially), unsure if they will fix this in time for 0.8 so I'd remove from the release?

@Silvyre
Copy link
Contributor

Silvyre commented Mar 3, 2020

Ah, sure, good call; let's do that

@raygervais raygervais self-assigned this Mar 3, 2020
@lozinska lozinska closed this as completed Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants