Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnhandledPromiseRejectionWarnings in our tests #570

Closed
humphd opened this issue Jan 21, 2020 · 3 comments
Closed

UnhandledPromiseRejectionWarnings in our tests #570

humphd opened this issue Jan 21, 2020 · 3 comments
Labels
type: bug Something isn't working type: test Creation and development of test

Comments

@humphd
Copy link
Contributor

humphd commented Jan 21, 2020 

npm test
...
 PASS  test/server.test.js (10.001s)
(node:45950) UnhandledPromiseRejectionWarning: StatusCodeError: 404 - "Not Found"
(node:45950) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:45950) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Let's see if we can get rid of these. @c3ho looks like we have some promise issues still somewhere.
@humphd humphd added type: bug Something isn't working type: test Creation and development of test labels Jan 21, 2020
@c3ho c3ho removed their assignment Mar 2, 2020
@humphd
Copy link
Contributor Author

humphd commented Apr 14, 2020

https://twitter.com/matteocollina/status/1248280519927902210 might help

@HyperTHD
Copy link
Contributor

Discovered when running this test file
image

@chrispinkney chrispinkney added this to the 1.9 Release milestone Mar 16, 2021
@huyxgit huyxgit removed this from the 1.9.5 Release milestone Apr 6, 2021
@humphd
Copy link
Contributor Author

humphd commented Oct 9, 2021

I don't see this anymore, closing.

@humphd humphd closed this as completed Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something isn't working type: test Creation and development of test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@humphd @chrispinkney @huyxgit @HyperTHD @c3ho @yuanLeeMidori