Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spam-filter module and associated code #415

Closed
humphd opened this issue Dec 3, 2019 · 5 comments · Fixed by #781
Closed

Remove spam-filter module and associated code #415

humphd opened this issue Dec 3, 2019 · 5 comments · Fixed by #781
Assignees
Labels
5 min fix Fixable in 5 minutes or less area: back-end good first issue Good for newcomers

Comments

@humphd
Copy link
Contributor

humphd commented Dec 3, 2019

We're having issues using the https://www.npmjs.com/package/spam-filter module, since it depends on a really old version of node. Let's remove it, or replace it.

We're not currently using spam filtering at all, so it's critical to have this (yet).

@cindyorangis
Copy link
Contributor

Seeing how spam-filter hasn't been updated in 2 years and depends on node 8 and npm 5... I started digging around our packages to see which ones are also in the same boat where it hasn't been updated in a while.

opml-generator (5 years ago)
parse-github-url (2 years ago)
passport (2 years ago)
passport-openid (4 years ago)
reading-level (2 years ago)
wordcount (4 years ago)
valid-url (6 years ago)

These aren't complaining now but I'm worried that they might complain in the future @_@
Am I overthinking or are these ticking time bombs?

@c3ho
Copy link
Contributor

c3ho commented Jan 21, 2020

@cindyledev Thank you for the good point. As she pointed out, this hasn't been updated in 2 years and its dependencies will conflict with the rest of our other libraries. We have decided to remove the spam-filter module and remove any tests associated with the module.

@c3ho c3ho closed this as completed Jan 21, 2020
@c3ho c3ho reopened this Jan 21, 2020
@c3ho c3ho added 5 min fix Fixable in 5 minutes or less good first issue Good for newcomers labels Jan 21, 2020
@humphd humphd changed the title Remove/replace spam-filter module Remove spam-filter module and associated code Jan 21, 2020
@c3ho
Copy link
Contributor

c3ho commented Jan 22, 2020

@humphd are you ok with me assigning it to you so your students can take this issue?

@humphd
Copy link
Contributor Author

humphd commented Jan 22, 2020

That, or assign it to yourself, and you can mentor. Either works.

@c3ho c3ho assigned agarcia-caicedo and unassigned humphd Mar 2, 2020
@humphd humphd assigned humphd and unassigned agarcia-caicedo Mar 3, 2020
@humphd
Copy link
Contributor Author

humphd commented Mar 3, 2020

I'm going to steal this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 min fix Fixable in 5 minutes or less area: back-end good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants