Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Preemptive] CSS issues with real-world blog post elements and content #366

Closed
lucacataldo opened this issue Nov 28, 2019 · 1 comment
Closed
Assignees

Comments

@lucacataldo
Copy link
Contributor

lucacataldo commented Nov 28, 2019

Once #346 gets merged, we will see some sample posts being rendered with real-world blog content on the front-end. While working on this, I came across some issues with the CSS where titles would overflow, responsive views weren't optimized and various other smaller fixes to the UI that could use some polishing. In the review, others made a valid point that these fixes shouldn't be included in that PR. Since I've got a lot of fixes to these little UI bugs ready to go, I figured I'd put up an issue so that the same work isn't done twice when the code is merged.

Specifics:

  • Mobile view post header is broken with longer titles
  • Images can cause overflow
  • <ol> and <ul> can overflow the <article> container
  • Whitespace can overflow the body, meaning that horizontal scroll bars appear when they shouldn't
  • Google Translate toolbar is awkwardly placed
  • Search bar button renders improperly
  • Various smaller CSS fixes
@miggs125
Copy link
Contributor

Hey @lucacataldo, we've decided to go a different direction so we will be closing this issue. Feel free to checkout our open issues and contribute there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants