-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile UX/UI accordion behavior improvement #2708
Comments
Hi there! Just a heads up, I am certain the sticky title is not done automatically. Alex can you please post an image of what its currently behaving like? I am not aware of what this looks like. |
I have a PR #2716 opened |
I'm pretty sure #2716 does not fix this. This is why I made another issue. So that the old issue gets fixed while the more difficult task gets passed on. Tue's PR would still have a problem described here. I need confirmation from @TueeNguyen , and then the PR should be unlinked. |
If I'm correct, I think we are talking about the title expanding sometimes if it's too long: chrome_DnMOPgsplU.mp4However i'm confused which PR has the accordion... right now only Tue's is going to present this new feature, and we should ship it. We can keep this issue open afterwards as the issue persists. @TueeNguyen we can unlink this issue, let's ship your stuff it's great! We will file following bugs. |
I just noticed that when header is open, the title is though sticky, it moves down a little which takes more space. I'll unlink this issue from the PR #2716 |
@TueeNguyen Let's make a new issue for this. They are around the same area, but they are not the same. It should be really good first issue! |
can I take this issue for hacktoberfest? |
Can someone ping me when PR for this issue is created? I did big parts of the mobile view. @DiegoHdz7 |
Sure |
Closing since the mobile version of telescope was removed in #3805 |
Continuation of #2373
Two tasks.
Yes, I drew that smol github icon <_<
Solution: When clicking to expand the accordeon, do not expand the sticky title, but move the user to the original title's location and only there expand the details. This is more difficult to implement because stickiness of the title is currently done automatically with material design. We would need to code the solution ourselves, finding where the title is located and moving the screen there.
The text was updated successfully, but these errors were encountered: