Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile UX/UI accordion behavior improvement #2708

Closed
sirinoks opened this issue Jan 22, 2022 · 12 comments
Closed

Mobile UX/UI accordion behavior improvement #2708

sirinoks opened this issue Jan 22, 2022 · 12 comments
Assignees
Labels
area: accessibility Making Telescope accessible for all kinds of users area: css styling Anything related to CSS styling area: design Issues needing design or assets area: front-end type: enhancement New feature or request

Comments

@sirinoks
Copy link
Contributor

Continuation of #2373

Two tasks.

  1. Add a github icon (with an arrow) to the right of the title (should take about 10-15% of the space of the title div). If you click on the title, you will get linked to the original post. If you click on the icon, an accordeon with extra information (PRs, issues) will expand. (easy)

Yes, I drew that smol github icon <_<
  1. Problem: Currently the title "sticks" to the top of the page as you scroll through the current post. If you expand the accordeon on such "sticky" title, the extra information will take up the whole screen.
    Solution: When clicking to expand the accordeon, do not expand the sticky title, but move the user to the original title's location and only there expand the details. This is more difficult to implement because stickiness of the title is currently done automatically with material design. We would need to code the solution ourselves, finding where the title is located and moving the screen there.
@sirinoks sirinoks added type: enhancement New feature or request area: front-end area: design Issues needing design or assets area: css styling Anything related to CSS styling area: accessibility Making Telescope accessible for all kinds of users labels Jan 22, 2022
@AmasiaNalbandian
Copy link
Contributor

Hi there! Just a heads up, I am certain the sticky title is not done automatically. Alex can you please post an image of what its currently behaving like? I am not aware of what this looks like.

@DukeManh DukeManh changed the title Mobile UX/UI accordeon behavior improvement Mobile UX/UI accordin behavior improvement Jan 22, 2022
@DukeManh DukeManh changed the title Mobile UX/UI accordin behavior improvement Mobile UX/UI accordion behavior improvement Jan 22, 2022
@TueeNguyen
Copy link
Contributor

I have a PR #2716 opened

@sirinoks
Copy link
Contributor Author

I'm pretty sure #2716 does not fix this. This is why I made another issue. So that the old issue gets fixed while the more difficult task gets passed on. Tue's PR would still have a problem described here. I need confirmation from @TueeNguyen , and then the PR should be unlinked.
@TueeNguyen In your PR, if you open the accordeon while the title is fixed at the top, the accordeon will take a bunch of the page's space, making it hard to navigate and see the post itself, correct?

@AmasiaNalbandian
Copy link
Contributor

If I'm correct, I think we are talking about the title expanding sometimes if it's too long:

chrome_DnMOPgsplU.mp4

However i'm confused which PR has the accordion... right now only Tue's is going to present this new feature, and we should ship it. We can keep this issue open afterwards as the issue persists.

@TueeNguyen we can unlink this issue, let's ship your stuff it's great! We will file following bugs.

@TueeNguyen
Copy link
Contributor

I just noticed that when header is open, the title is though sticky, it moves down a little which takes more space. I'll unlink this issue from the PR #2716

@TueeNguyen
Copy link
Contributor

We could also reduce the gap between this bottom icon and other information
image

@AmasiaNalbandian
Copy link
Contributor

We could also reduce the gap between this bottom icon and other information image

@TueeNguyen Let's make a new issue for this. They are around the same area, but they are not the same. It should be really good first issue!

@RC-Lee RC-Lee added this to the 2.9 Release milestone Mar 15, 2022
@TueeNguyen TueeNguyen removed their assignment Mar 15, 2022
@AmasiaNalbandian
Copy link
Contributor

This is the solution:
image

add max-height overflow-y

@AmasiaNalbandian AmasiaNalbandian added the 5 min fix Fixable in 5 minutes or less label Mar 22, 2022
@nguyenhung15913 nguyenhung15913 removed the 5 min fix Fixable in 5 minutes or less label Mar 29, 2022
@nguyenhung15913 nguyenhung15913 removed this from the 3.0-alpha Release milestone Mar 29, 2022
@DiegoHdz7
Copy link

DiegoHdz7 commented Oct 10, 2022

can I take this issue for hacktoberfest?

@TueeNguyen
Copy link
Contributor

TueeNguyen commented Oct 11, 2022

Can someone ping me when PR for this issue is created? I did big parts of the mobile view. @DiegoHdz7

@DiegoHdz7
Copy link

Sure

@manekenpix
Copy link
Member

Closing since the mobile version of telescope was removed in #3805

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: accessibility Making Telescope accessible for all kinds of users area: css styling Anything related to CSS styling area: design Issues needing design or assets area: front-end type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants